This repository has been archived by the owner on Apr 9, 2022. It is now read-only.
fix(@angular-devkit/build-angular): support some browser options in dev-server #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
previously approved these changes
Apr 18, 2018
filipesilva
suggested changes
Apr 18, 2018
| "optimization": { | ||
| "type": "boolean", | ||
| "description": "Defines the optimization level of the build.", | ||
| "default": false |
There was a problem hiding this comment.
These options cannot have a default, otherwise the default will always override the browser target values.
Yes, and that's what my other PR that I got carried away with is about; enabling us to walk the schema properly to discover options. Let's not get distracted for 6.0 though and implement |
hansl
force-pushed
the
fix-10304
branch
2 times, most recently
from
d7b599a to
3957323
Compare
filipesilva
suggested changes
Apr 18, 2018
| @@ -51,6 +51,15 @@ export interface DevServerBuilderOptions { | |||
| watch: boolean; | |||
| hmrWarning: boolean; | |||
| servePathDefaultWarning: boolean; | |||
|
|
|||
| optimization: boolean; | |||
There was a problem hiding this comment.
These are all optional now.
…ev-server This will allow people to override some flags from a base browser target, either from the command line or from their serve directly. The options chosen are kinda arbitrary. I simply looked at what made sense. Fix angular/angular-cli#10304
filipesilva
approved these changes
Apr 18, 2018
34 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow people to override some flags from a base browser target, either from
the command line or from their serve directly.
The options chosen are kinda arbitrary. I simply looked at what made sense.
Fix angular/angular-cli#10304