Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github-actions): properly pass auth token to octokit #897

Closed

Conversation

devversion
Copy link
Member

The octokit options literaly is weakly typed and doesn't validate that auth is set. The token is currently provided to an unknown field that isn't respected. This is likely the reason for the bearer token header logic, so I removed this.

The octokit options literaly is weakly typed and doesn't validate
that `auth` is set. The token is currently provided to an unknown
field that isn't respected. This is likely the reason for the
bearer token header logic, so I removed this.
@devversion devversion force-pushed the fix-branch-manager-assistant-token branch from e085814 to a4c6572 Compare November 7, 2022 16:15
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Nov 7, 2022
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angular-robot
Copy link
Contributor

angular-robot bot commented Nov 14, 2022

This PR was merged into the repository by commit df2f203.

@angular-robot angular-robot bot closed this in df2f203 Nov 14, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants