Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ng-dev): automatically remove credentials generated by ng-dev auth service after use #776

Closed

Conversation

josephperrott
Copy link
Member

After use, the credentials generated by the ng-dev auth service are automatically requested
to be removed from any git credential helper which is currently active.

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Aug 17, 2022
…th service after use

After use, the credentials generated by the ng-dev auth service are automatically requested
to be removed from any git credential helper which is currently active.
@josephperrott josephperrott force-pushed the git-remote-credential branch from 3a7575d to 67d5f4d Compare August 17, 2022 20:32
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

Would love to see the same for our --github-token flag, but I assume we need to be careful not wiping actual user tokens. (We could annotate our username with something special like ng-dev-x-github-token)

@angular-robot
Copy link
Contributor

angular-robot bot commented Aug 17, 2022

This PR was merged into the repository by commit f502be3.

@angular-robot angular-robot bot closed this in f502be3 Aug 17, 2022
@josephperrott josephperrott deleted the git-remote-credential branch August 17, 2022 21:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants