Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle setting github authentication with respect to ng-dev auth service #774

Closed
wants to merge 8 commits into from
Closed

Properly handle setting github authentication with respect to ng-dev auth service #774

wants to merge 8 commits into from

Conversation

josephperrott
Copy link
Member

See individual commits.

@josephperrott
refactor(ng-dev): retrieve github token from the authentication git c…
2de25ea 
…lient rather than params

Previously a few commands relied on the github token being passed in to the function rather
than retrieving it from the configured AuthenticatedGitClient. We should not pass around this
token, but instead retrieve it from the configured client.
@josephperrott
refactor(ng-dev): remove the unncessary type of githubToken from the …
673bd54 
…yargs args object

Because the github token is not to be directly used from the yargs args object, it is now
instead collected for authentication of the GitClient and then hidden from the other uses.
@josephperrott
fix(ng-dev): properly handle github token escapes with ng-dev service…
a39537b 
… auth

We now correctly handle when the github-escape-hatch is used and don't always
assume that a github token should be checked for.
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 17, 2022
devversion
devversion approved these changes Aug 17, 2022
View reviewed changes
ng-dev/utils/git/github-yargs.ts Outdated Show resolved Hide resolved
@josephperrott josephperrott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Aug 17, 2022
@josephperrott
fix(ng-dev): assorted typing fixes that typescript wants
2db327b 
Types has begun to want more specific commits in some of our mapping functions related to Github API responses.
@angular-robot
Copy link
Contributor

angular-robot bot commented Aug 17, 2022

This PR was merged into the repository by commit ba8f786.

@angular-robot angular-robot bot closed this in 8824bd0 Aug 17, 2022
angular-robot bot pushed a commit that referenced this pull request Aug 17, 2022
@josephperrott
refactor(ng-dev): remove the unncessary type of githubToken from the …
0bb6369 
…yargs args object (#774)

Because the github token is not to be directly used from the yargs args object, it is now
instead collected for authentication of the GitClient and then hidden from the other uses.

PR Close #774
angular-robot bot pushed a commit that referenced this pull request Aug 17, 2022
@josephperrott
fix(ng-dev): properly handle github token escapes with ng-dev service…
8d1d6c5 
… auth (#774)

We now correctly handle when the github-escape-hatch is used and don't always
assume that a github token should be checked for.

PR Close #774
angular-robot bot pushed a commit that referenced this pull request Aug 17, 2022
@josephperrott
fix(ng-dev): assorted typing fixes that typescript wants (#774)
ba8f786 
Types has begun to want more specific commits in some of our mapping functions related to Github API responses.

PR Close #774
devversion added a commit to devversion/dev-infra that referenced this pull request Aug 17, 2022
@devversion
Revert "fix(ng-dev): assorted typing fixes that typescript wants (ang…
9f10afc 
…ular#774)"

This reverts commit ba8f786.
angular-robot bot pushed a commit that referenced this pull request Aug 17, 2022
@devversion
Revert "fix(ng-dev): assorted typing fixes that typescript wants (#774)…
b313041 
…" (#775)

This reverts commit ba8f786.

PR Close #775
@josephperrott josephperrott deleted the handle-git-options branch August 17, 2022 21:13
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephperrott @devversion