-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apps): create credential service server #729
feat(apps): create credential service server #729
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a docker file?
494bccb
to
5bb34bd
Compare
Create the credential service server. When logged in with an ng-dev token, allows for a user to request via websocket, a temporary Github credential.
5bb34bd
to
8bca49e
Compare
Updated the commit message originally, but then Github decided to not update the title and summary for the PR when I pushed again. Its corrected now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
aafdb17
to
d2fc055
Compare
d2fc055
to
7a06cb9
Compare
This PR was merged into the repository by commit 1609543. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Create the credential service server. When logged in with an ng-dev token, allows for a user to request via websocket, a temporary Github credential.