Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps): create credential service server #729

Closed

Conversation

josephperrott
Copy link
Member

@josephperrott josephperrott commented Jul 20, 2022

Create the credential service server. When logged in with an ng-dev token, allows for a user to request via websocket, a temporary Github credential.

@josephperrott josephperrott added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 20, 2022
@josephperrott josephperrott requested a review from devversion July 20, 2022 16:20
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a docker file?

package.json Outdated Show resolved Hide resolved
apps/credential-service/lib/server.ts Outdated Show resolved Hide resolved
apps/credential-service/lib/server.ts Outdated Show resolved Hide resolved
apps/credential-service/lib/server.ts Outdated Show resolved Hide resolved
apps/credential-service/lib/server.ts Outdated Show resolved Hide resolved
@josephperrott josephperrott force-pushed the create-token-request-service branch from 494bccb to 5bb34bd Compare July 28, 2022 17:36
Create the credential service server. When logged in with an ng-dev token, allows for
a user to request via websocket, a temporary Github credential.
@josephperrott josephperrott force-pushed the create-token-request-service branch from 5bb34bd to 8bca49e Compare July 28, 2022 17:38
@josephperrott josephperrott changed the title feat(apps): create credential service docker image feat(apps): create credential service server Jul 28, 2022
@josephperrott josephperrott requested a review from devversion July 28, 2022 18:07
@josephperrott
Copy link
Member Author

Updated the commit message originally, but then Github decided to not update the title and summary for the PR when I pushed again. Its corrected now.

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor comments

apps/credential-service/BUILD.bazel Show resolved Hide resolved
apps/credential-service/lib/server.ts Outdated Show resolved Hide resolved
apps/credential-service/lib/server.ts Outdated Show resolved Hide resolved
apps/credential-service/lib/server.ts Outdated Show resolved Hide resolved
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

apps/credential-service/lib/server.ts Outdated Show resolved Hide resolved
@josephperrott josephperrott force-pushed the create-token-request-service branch from aafdb17 to d2fc055 Compare July 29, 2022 21:07
@josephperrott josephperrott force-pushed the create-token-request-service branch from d2fc055 to 7a06cb9 Compare July 29, 2022 21:10
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 29, 2022
@josephperrott
Copy link
Member Author

This PR was merged into the repository by commit 1609543.

@josephperrott josephperrott deleted the create-token-request-service branch July 29, 2022 21:14
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants