Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ng-dev): validate all licenses as being allowed for our Angular projects #644

Closed
wants to merge 5 commits into from

Conversation

josephperrott
Copy link
Member

A tool for validating that all packages provide allowed licenses in our projects.

@josephperrott josephperrott added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jun 27, 2022
@josephperrott josephperrott requested a review from devversion June 27, 2022 19:38
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, just some comments

ng-dev/misc/cli.ts Outdated Show resolved Hide resolved
ng-dev/misc/BUILD.bazel Outdated Show resolved Hide resolved
ng-dev/misc/validate-licenses/cli.ts Outdated Show resolved Hide resolved
ng-dev/misc/validate-licenses/cli.ts Outdated Show resolved Hide resolved
ng-dev/misc/validate-licenses/validate.ts Outdated Show resolved Hide resolved
ng-dev/misc/validate-licenses/validate.ts Outdated Show resolved Hide resolved
ng-dev/misc/validate-licenses/validate.ts Outdated Show resolved Hide resolved
ng-dev/misc/validate-licenses/validate.ts Show resolved Hide resolved
ng-dev/misc/validate-licenses/validate.ts Outdated Show resolved Hide resolved
@josephperrott josephperrott force-pushed the validate-licenses branch 3 times, most recently from 97c61f4 to 3e1bf2c Compare August 18, 2022 15:07
@josephperrott josephperrott marked this pull request as ready for review August 18, 2022 15:07
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 18, 2022
ng-dev/BUILD.bazel Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@devversion devversion added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 19, 2022
@josephperrott josephperrott removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Aug 19, 2022
bazel/esbuild/index.bzl Outdated Show resolved Hide resolved
@angular-robot
Copy link
Contributor

angular-robot bot commented Aug 19, 2022

This PR was merged into the repository by commit 613e401.

@angular-robot angular-robot bot closed this in 613e401 Aug 19, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 19, 2022
@josephperrott josephperrott deleted the validate-licenses branch December 9, 2022 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants