Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): setup karma web test wrapper with "local" debug target #403

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

devversion
Copy link
Member

Sets up a karma web test wrapper with the "local" debug target that
is commonly set up in framework and the components repo. It seems
reasonable maintaining this logic in one place.

Sets up a karma web test wrapper with the "local" debug target that
is commonly set up in framework and the components repo. It seems
reasonable maintaining this logic in one place.
@devversion
Copy link
Member Author

devversion commented Feb 11, 2022

We can wire this up in the test from #395

@devversion devversion added the action: review The PR is still awaiting reviews from at least one requested reviewer label Feb 11, 2022
@devversion devversion requested a review from gkalpak February 11, 2022 20:51
gkalpak
gkalpak previously approved these changes Feb 11, 2022
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ✨

bazel/karma/index.bzl Outdated Show resolved Hide resolved
bazel/karma/index.bzl Outdated Show resolved Hide resolved
@gkalpak gkalpak dismissed their stale review February 11, 2022 21:28

I meant to just comment.

@devversion devversion requested a review from gkalpak February 12, 2022 08:54
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@devversion devversion merged commit a3ad969 into angular:main Feb 14, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants