Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): integration test rule not able to setup mappings for resolutions #286

Conversation

devversion
Copy link
Member

Fixes that the Bazel integration test rule is not able to setup mappings
for Yarn resolutions because the record keys do not exactly match to a
package name, but rather follow certain allowed patterns, like
**/<pkg-name>.

@devversion devversion added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 7, 2021
@devversion devversion requested a review from gkalpak November 7, 2021 12:43
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments and suggestions. Otherwise lgtm 👍

bazel/integration/test_runner/package_json.ts Outdated Show resolved Hide resolved
bazel/integration/tests/package_mappings/test.mjs Outdated Show resolved Hide resolved
bazel/integration/test_runner/package_json.ts Show resolved Hide resolved
bazel/integration/test_runner/package_json.ts Show resolved Hide resolved
bazel/integration/test_runner/package_json.ts Outdated Show resolved Hide resolved
…lutions

Fixes that the Bazel integration test rule is not able to setup mappings
for Yarn resolutions because the record keys do not exactly match to a
package name, but rather follow certain allowed patterns, like
`**/<pkg-name>`.
@devversion devversion force-pushed the fix/integration-support-resolution-patterns branch from c574738 to e05e4b0 Compare November 8, 2021 15:07
@devversion devversion merged commit ff39f60 into angular:main Nov 8, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: review The PR is still awaiting reviews from at least one requested reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants