Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bazel): add support for custom environment variables in integration tests #270

Merged

Conversation

devversion
Copy link
Member

Adds support for custom environment variables in integration tests. The
environment variable dictionary can use location expansion. Also there
is a special placeholder called <TMP> that can be used to acquire a
temporary directory. This is useful when setting up tools like BAZELISK,
which requires a HOME environment variable as an example.

@devversion devversion added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 15, 2021
@devversion devversion force-pushed the feat/bazel-custom-env-for-integration-tests branch from 1647e31 to fd4a854 Compare October 15, 2021 17:31
…ion tests

Adds support for custom environment variables in integration tests. The
environment variable dictionary can use location expansion. Also there
is a special placeholder called `<TMP>` that can be used to acquire a
temporary directory. This is useful when setting up tools like BAZELISK,
which requires a `HOME` environment variable as an example.
@devversion devversion force-pushed the feat/bazel-custom-env-for-integration-tests branch from fd4a854 to 67d76fa Compare October 15, 2021 17:42
bazel/integration/test_runner/runner.ts Show resolved Hide resolved
bazel/integration/test_runner/runner.ts Outdated Show resolved Hide resolved
bazel/integration/index.bzl Show resolved Hide resolved
@devversion
Copy link
Member Author

@josephperrott Done. please have another look

Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion merged commit 3cc5232 into angular:main Oct 15, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants