Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng-dev): add DEPRECATION to invalid commit message #250

Closed
wants to merge 1 commit into from

Conversation

alan-agius4
Copy link
Collaborator

At the moment if DEPRECATION : is used to mark deprecations the commit validation will not fail. This PR addresses this.

At the moment if `DEPRECATION :` is used to mark deprecations the commit validation will not fail. This PR addresses this.
@google-cla google-cla bot added the cla: yes label Oct 7, 2021
@alan-agius4 alan-agius4 added domain: pr automation action: review The PR is still awaiting reviews from at least one requested reviewer and removed cla: yes labels Oct 7, 2021
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 7, 2021
@josephperrott
Copy link
Member

This PR was merged into the repository by commit 87ee867.

@alan-agius4 alan-agius4 deleted the DEPRECATION-handle branch October 7, 2021 20:15
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker domain: pr automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants