Update status/checks retrieval from Github, move validation of CLA to use status instead of the label, move other validators to common location #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
the
action: review
josephperrott
force-pushed
the
validate-combined-status
branch
2 times, most recently
from
cf69b01 to
43115f1
Compare
josephperrott
changed the title
devversion
approved these changes
Sep 26, 2021
josephperrott
added
action: merge
josephperrott
force-pushed
the
validate-combined-status
branch
from
c858732 to
b80e3ee
Compare
…d normalize them together Previously we only retrieved the status for a pull request rather than also retrieving the results for github check runs on commits. It is more accurate to retrieve both and normalize them together to check all statuses during validation.
…er-new-conflicts Use the common fetch pr functions to get the pr from github in the discover-new-conflicts command.
…atus on pr merges Rather than check if the CLA is signed based on the presense of a label, the cla/google status should be used. BREAKING CHANGE: `claSignedLabel` is not longer used as an attribute on the `PullRequestConfig`
Move the merge ready label check validation to the common validations.
…valiations Move the check of the overall CI pending or failing check to the common validations.
josephperrott
force-pushed
the
validate-combined-status
branch
from
b80e3ee to
4737402
Compare
|
This PR was merged into the repository by commit 93e501e. |
josephperrott
added a commit
that referenced
this pull request
Sep 27, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.