Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ng-dev/release): Use new changelog writer each time an entry is prepending to the changelog file #224

Merged

Conversation

josephperrott
Copy link
Member

Creating a new changelog writer instance reach time the ReleaseNotes prepends to the changelog ensures
that even in cases where we "cherry-pick" the entry, old entries are not removed from the changelog file.

…repending to the changelog file

Creating a new changelog writer instance reach time the ReleaseNotes prepends to the changelog ensures
that even in cases where we "cherry-pick" the entry, old entries are not removed from the changelog file.
@josephperrott josephperrott added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 16, 2021
@google-cla google-cla bot added the cla: yes label Sep 16, 2021
@devversion devversion merged commit ad534e2 into angular:main Sep 16, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 17, 2021
@josephperrott josephperrott deleted the fix-cherry-picking-during-release branch August 10, 2022 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants