Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ng-dev): add safety checks for shallow repositories #218

Closed

Conversation

devversion
Copy link
Member

Adds safety checks for shallow repositories when executing
the merge or release publish script. These two commands
have similar checks on the local repository and these tools
act on the local repository as part of a common development
workflow where an error beforehand would be more useful.

@google-cla google-cla bot added the cla: yes label Sep 14, 2021
@devversion devversion added action: merge The PR is ready for merge by the caretaker action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 14, 2021
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Adds safety checks for shallow repositories when executing
the merge or release publish script. These two commands
have similar checks on the local repository and these tools
act on the local repository as part of a common development
workflow where an error beforehand would be more useful.
@josephperrott josephperrott force-pushed the feat/safety-shallow-checks branch from 2c7b05f to 2168877 Compare September 14, 2021 22:42
@josephperrott josephperrott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Sep 14, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants