Skip to content

Commit

Permalink
fix(bazel/browsers): exclude chromium debug logs on remaining platforms
Browse files Browse the repository at this point in the history
  • Loading branch information
kormide authored and devversion committed Oct 7, 2022
1 parent c9b2ff0 commit b12cd73
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions bazel/browsers/chromium/chromium.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ def define_chromium_repositories():
"CHROMIUM": "chrome-linux/chrome",
},
exclude_patterns = [
# Exclude a log file that chromium writes to each run, causing remote cache
# misses in downstream targets.
# Exclude a log file that chromium writes to each run, causing remote cache misses.
"chrome-linux/chrome_debug.log",
],
exports_files = ["chrome-linux"],
Expand All @@ -41,6 +40,10 @@ def define_chromium_repositories():
named_files = {
"CHROMIUM": "chrome-mac/Chromium.app/Contents/MacOS/Chromium",
},
exclude_patterns = [
# Exclude a log file that chromium writes to each run, causing remote cache misses.
"chrome-mac/Chromium.app/Contents/Frameworks/Chromium Framework.framework/Versions/*/chrome_debug.log",
],
exports_files = ["chrome-mac"],
)

Expand All @@ -56,6 +59,10 @@ def define_chromium_repositories():
named_files = {
"CHROMIUM": "chrome-mac/Chromium.app/Contents/MacOS/Chromium",
},
exclude_patterns = [
# Exclude a log file that chromium writes to each run, causing remote cache misses.
"chrome-mac/Chromium.app/Contents/Frameworks/Chromium Framework.framework/Versions/*/chrome_debug.log",
],
exports_files = ["chrome-mac"],
)

Expand All @@ -74,6 +81,8 @@ def define_chromium_repositories():
exclude_patterns = [
# Exclude files with spaces to prevent errors when symlinked as runfiles (https://github.com/bazelbuild/bazel/issues/4327).
"chrome-win/First Run",
# Exclude a log file that chromium writes to each run, causing remote cache misses.
"chrome-win/debug.log",
],
exports_files = ["chrome-win"],
)
Expand Down

0 comments on commit b12cd73

Please sign in to comment.