Skip to content

Commit

Permalink
refactor: more obvious release building message (#360)
Browse files Browse the repository at this point in the history
Makes the release building spinner a little more helpful by indicating
that this could take a few minutes.

PR Close #360
  • Loading branch information
devversion authored and josephperrott committed Jan 27, 2022
1 parent 8298e12 commit 5fbb98b
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion ng-dev/release/publish/external-commands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ export async function invokeReleaseBuildCommand(
// a different publish branch and the current `PATH` will point to the Yarn version
// that invoked the release tool. More details in the function description.
const yarnCommand = await resolveYarnScriptForProject(projectDir);
const spinner = new Spinner('Building release output.');
// Note: We explicitly mention that this can take a few minutes, so that it's obvious
// to caretakers that it can take longer than just a few seconds.
const spinner = new Spinner('Building release output. This can take a few minutes.');

try {
// Since we expect JSON to be printed from the `ng-dev release build` command,
Expand Down

0 comments on commit 5fbb98b

Please sign in to comment.