refactor(ng-dev): move all AuthenticatedGitClient configuration to be…

… through single configure function (#180)

PR Close #180

github-actions/slash-commands/lib/commands/rebase.ts

@@ -3,13 +3,19 @@ import {Octokit} from '@octokit/rest';
 import {context} from '@actions/github';
 import {getAuthTokenFor, ANGULAR_ROBOT} from '../../../utils';
 import {AuthenticatedGitClient} from '../../../../ng-dev/utils/git/authenticated-git-client';
+import {setConfig} from '../../../../ng-dev/utils/config';
 
 export async function rebase() {
   const token = await getAuthTokenFor(ANGULAR_ROBOT);
-  const {owner, repo: name} = context.repo;
-  const mainBranchName = context.payload.repository!.default_branch;
+  setConfig({
+    github: {
+      name: context.repo.repo,
+      owner: context.repo.owner,
+      mainBranchName: context.payload.repository!.default_branch,
+    },
+  });
 
-  AuthenticatedGitClient.configureForGithubActions(token, {github: {name, owner, mainBranchName}});
+  AuthenticatedGitClient.configure(token);
 
   if ((await rebasePr(context.issue.number, token)) !== 0) {
     // For any failure to rebase, comment on the PR informing the user a rebase was unable to be

ng-dev/utils/git/authenticated-git-client.ts

@@ -127,25 +127,6 @@ export class AuthenticatedGitClient extends GitClient {
         'Unable to configure `AuthenticatedGitClient` as it has been configured already.',
       );
     }
-    if (process.env['GITHUB_ACTIONS']) {
-      throw Error(
-        'Cannot use `configure` static method to create AuthenticatedGitClient in a Github Action.',
-      );
-    }
     AuthenticatedGitClient._authenticatedInstance = new AuthenticatedGitClient(token);
   }
-
-  /** Configures an authenticated git client in the context of a Github action. */
-  static configureForGithubActions(token: string, config: {github: GithubConfig}): void {
-    if (AuthenticatedGitClient._authenticatedInstance) {
-      throw Error(
-        'Unable to configure `AuthenticatedGitClient` as it has been configured already.',
-      );
-    }
-    AuthenticatedGitClient._authenticatedInstance = new AuthenticatedGitClient(
-      token,
-      undefined,
-      config,
-    );
-  }
 }