Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add mat-select-header and mat-select-search component #8050

Closed
wants to merge 1 commit into from
Closed

feat(select): add mat-select-header and mat-select-search component #8050

wants to merge 1 commit into from

Conversation

albyrock87
Copy link
Contributor

This is a continuation of #7835 that fixes some bugs and adds an integrated search functionality.

Adds a mat-select-header component, which is a fixed header above the select's options. It allows for the user to put anything there: a custom text, or any focusable element (inputs, ...).
Note: This component only handles the positioning, styling, some basic focus management and exposes the panel id for a11y.

Adds a mat-select-search component, which can be placed inside mat-select-header. It renders a special input field that manages long list filtering automatically.
Note: The user can use his own custom search function. This input can also be used to handle the options filtering from outside.

Fixes #2812.

Adds a `mat-select-header` component, which is a fixed header above the select's options. It allows for the user to put anything there: a custom text, or any focusable element (inputs, ...).
**Note:** This component only handles the positioning, styling, some basic focus management and exposes the panel id for a11y.

Adds a `mat-select-search` component, which can be placed inside `mat-select-header`. It renders a special input field that manages long list filtering automatically.
**Note:** The user can use his own custom search function. This input can also be used to handle the options filtering from outside.

Fixes #2812.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 26, 2017
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but this really isn't the proper way to go about changes like these.

  1. You took all of my work from feat(select): add mat-select-header component #7835 and are basically claiming it as your own by resubmitting it. It may be open source, but that doesn't mean that it's a free-for-all.
  2. When it comes to large changes like this, it is better to open an issue where we can have a discussion about the API and implementation. We usually write a design doc for larger features as well.
  3. Building on top of point two, if this had gone through the proper channels, it would've been obvious earlier that this goes against a lot of the design principles in the library. For example you're adding things to the CDK only to accommodate a case that is very specific to the select.

@albyrock87
Copy link
Contributor Author

First of all I'm really sorry about the first point. I did non intend to "steal" your work, I just wanted to contribute to the project!
About the other two point I didn't know about those "proper things".
I will eventually open a new issue or reuse the existing one so we can discuss about the search feature.

Thank you

@willshowell
Copy link
Contributor

willshowell commented Oct 26, 2017

@albyrock87 if you'd like to contribute, try working on a smaller feature! There are many listed here that already have clear expectations and won't require a design document. Be sure to avoid ones that already have PRs and are just pending merge. Another great way to contribute is to make updates to the documentation that you find to be confusing or lacking.

@jelbourn jelbourn closed this Nov 20, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(select): Add select header to the md-select
5 participants