-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to angular rc3 & newest router #729
Conversation
CI failure is due to https://github.com/angular/vladivostok/issues/95 |
@@ -5,7 +5,7 @@ | |||
<meta charset="utf-8"> | |||
<meta name="viewport" content="width=device-width, initial-scale=1"> | |||
<title>Material2</title> | |||
<base href="/"> | |||
<base href="."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
Isn't this the same as not having a base
tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Angular requires an explicit base tag, and the docs recommend this value.
LGTM except for @robertmesserle's comment. |
And we probably want to wait for that router issue to be fixed since master will become red. |
Yeah, waiting on Victor to fix the circular dep in the router. |
Please be careful because base href="." May break apps using webpack. |
We have constant testing with webpack currently. Router v3 is ready for simple cases and Material2 is a good test bed for it. |
@Zigzag95 This use of the router is only for our own demo app and doesn't affect any consumers of the components. |
So It must be a peer depency or dev depency |
I think WIP. |
44eb9a5
to
7506eff
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
R: @hansl or @robertmesserle
Need the new router to work with offline compiler.