Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to angular rc3 & newest router #729

Merged
merged 1 commit into from
Jun 28, 2016

Conversation

jelbourn
Copy link
Member

R: @hansl or @robertmesserle

Need the new router to work with offline compiler.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 20, 2016
@jelbourn
Copy link
Member Author

@@ -5,7 +5,7 @@
<meta charset="utf-8">
<meta name="viewport" content="width=device-width, initial-scale=1">
<title>Material2</title>
<base href="/">
<base href=".">
Copy link
Contributor

@robertmesserle robertmesserle Jun 21, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Isn't this the same as not having a base tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular requires an explicit base tag, and the docs recommend this value.

@hansl
Copy link
Contributor

hansl commented Jun 21, 2016

LGTM except for @robertmesserle's comment.

@hansl
Copy link
Contributor

hansl commented Jun 21, 2016

And we probably want to wait for that router issue to be fixed since master will become red.

@jelbourn
Copy link
Member Author

Yeah, waiting on Victor to fix the circular dep in the router.

@aminebizid
Copy link

Please be careful because base href="." May break apps using webpack.
Why are you using v3 router?

@hansl
Copy link
Contributor

hansl commented Jun 22, 2016

We have constant testing with webpack currently. Router v3 is ready for simple cases and Material2 is a good test bed for it.

@jelbourn
Copy link
Member Author

@Zigzag95 This use of the router is only for our own demo app and doesn't affect any consumers of the components.

@aminebizid
Copy link

So It must be a peer depency or dev depency

@ddomingues
Copy link

Hi @Zigzag95 and @jelbourn

Wouldn't be interesting already update it to angular rc3?

@aminebizid
Copy link

I think WIP.

@jelbourn jelbourn force-pushed the newest-router branch 2 times, most recently from 44eb9a5 to 7506eff Compare June 25, 2016 00:20
@jelbourn jelbourn changed the title chore: update to angular rc2 & newest router chore: update to angular rc3 & newest router Jun 25, 2016
@sceendy sceendy mentioned this pull request Jun 27, 2016
@jelbourn jelbourn merged commit 02cee7b into angular:master Jun 28, 2016
@jelbourn jelbourn deleted the newest-router branch September 13, 2017 04:36
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants