Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix metadata exports for moment-adapter #7272

Merged
merged 1 commit into from
Sep 28, 2017
Merged

build: fix metadata exports for moment-adapter #7272

merged 1 commit into from
Sep 28, 2017

Conversation

devversion
Copy link
Member

@devversion devversion commented Sep 23, 2017 •
edited
Loading

Due to a re-export that uses the index shorthand, the exports inside of the bundled metadata file are empty. This seems to be caused by a bug in @angular/compiler-cli. A temporary fix is just using the expanded important.

Fixes #7262

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 23, 2017
@devversion
build: fix metadata exports for moment-adapter
48fb733 
Due to a re-export that uses the index shorthand, the exports inside of the bundled metadata file are empty. This seems to be caused by a bug in `@angular/compiler-cli`. A temporary fix is just using the expanded important.

Fixes angular#7262
@devversion devversion force-pushed the build/fix-metadata-moment-adapter branch from d461674 to 48fb733 Compare September 23, 2017 15:17
jelbourn
jelbourn approved these changes Sep 23, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 23, 2017
@devversion devversion added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Sep 24, 2017
@julianobrasil julianobrasil mentioned this pull request Sep 27, 2017
Closed
@devversion devversion added P2 The issue is important to a large percentage of users, with a workaround and removed P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Sep 27, 2017
@jelbourn jelbourn merged commit 807ce38 into angular:master Sep 28, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moment adapter compilation fails
4 participants
@devversion @jelbourn @googlebot @mmalerba