test(material/timepicker): update timepicker tests to match timepicker toggle changes #30335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essjay05
requested review from
crisbeto and
andrewseguin
and removed request for
a team
angular-robot
bot
added
area: build & ci
andrewseguin
approved these changes
Jan 15, 2025
|
Can you rebase this PR to the latest code? Seems to include the other PR commits |
andrewseguin
added
action: merge
Updates timepicker test to account for recent changes to adding a default aria-label to the timepicker toggle.
essjay05
force-pushed
the
add-timepicker-toggle-aria-labelledby
branch
from
dee8d58 to
6840f6c
Compare
angular-robot
bot
removed
the
area: build & ci
andrewseguin
pushed a commit
that referenced
this pull request
Jan 15, 2025
Updates timepicker test to account for recent changes to adding a default aria-label to the timepicker toggle. (cherry picked from commit b5f3d42)
andrewseguin
pushed a commit
that referenced
this pull request
Jan 15, 2025
Updates timepicker test to account for recent changes to adding a default aria-label to the timepicker toggle. (cherry picked from commit b5f3d42)
mmalerba
added a commit
that referenced
this pull request
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Timepicker.spec.ts to match recent changes to Timepicker toggle having
a default aria-label.