fix(material/stepper): switch away from animations module #30314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
mmalerba and
wagnermaciel
and removed request for
a team
crisbeto
force-pushed
the
stepper-no-animations
branch
from
8604c78 to
f8ec0cc
Compare
crisbeto
force-pushed
the
stepper-no-animations
branch
2 times, most recently
from
73bb3e6 to
a853634
Compare
wagnermaciel
approved these changes
Jan 13, 2025
crisbeto
force-pushed
the
stepper-no-animations
branch
7 times, most recently
from
93169b2 to
99e243d
Compare
Reworks the stepper so it uses CSS directly to animate, instead of going through the animations module. This both simplifies the setup and allows us to avoid the issues that come with the animations module.
crisbeto
force-pushed
the
stepper-no-animations
branch
from
99e243d to
a2d0218
Compare
|
@crisbeto is it possible to have those animations reusable, like in a mixin or something? For the folks that were consuming the animations module. |
|
We sort of tried this before with exporting the animation definitions and it didn't end up being super useful, because the animations are very much tied to our DOM structure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the stepper so it uses CSS directly to animate, instead of going through the animations module. This both simplifies the setup and allows us to avoid the issues that come with the animations module.