fix(material/datepicker): simplify DI setup #30247
Merged
+30
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
requested review from
amysorto and
wagnermaciel
and removed request for
a team
crisbeto
force-pushed
the
30238/date-range-di-setup
branch
from
0d1e741 to
983bb43
Compare
Previously we had to define an injection token for the `MatDateRangeInput` in order to avoid circular references. Now we can do the same with a type-only imports so we can simplify the setup. Fixes angular#30238.
crisbeto
force-pushed
the
30238/date-range-di-setup
branch
from
983bb43 to
8fda6fe
Compare
mmalerba
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had to define an injection token for the
MatDateRangeInputin order to avoid circular references. Now we can do the same with a type-only imports so we can simplify the setup.Fixes #30238.