Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting setContenteditableValue to plaintext-only for tests #29999

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

tatp22
Copy link
Contributor

@tatp22 tatp22 commented Nov 12, 2024

plaintext-only is a valid value for contenteditable that specifies that the raw text is editable but rich formatting is disabled. This is supported now for every browser except for Firefox, where it is now supported in a nightly version. See more specifications here.

@tatp22 tatp22 requested a review from a team as a code owner November 12, 2024 16:31
@tatp22 tatp22 requested review from crisbeto and amysorto and removed request for a team November 12, 2024 16:31
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Nov 12, 2024
@mmalerba mmalerba self-assigned this Nov 12, 2024
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 12, 2024
@mmalerba mmalerba merged commit b3c93c5 into angular:main Nov 13, 2024
18 of 21 checks passed
mmalerba pushed a commit that referenced this pull request Nov 13, 2024
mmalerba pushed a commit that referenced this pull request Nov 13, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants