Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/sidenav): prevent the content from jumping when hydrated #29991

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix(material/sidenav): prevent the content from jumping when hydrated #29991

merged 1 commit into from
Nov 11, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 9, 2024

Fixes that the content of the sidenav was jumping when the page is hydrated, because we can't measure the sidenav on the server.

@crisbeto
fix(material/sidenav): prevent the content from jumping when hydrated
e8719ad 
Fixes that the content of the sidenav was jumping when the page is hydrated, because we can't measure the sidenav on the server.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 9, 2024
@crisbeto crisbeto requested a review from a team as a code owner November 9, 2024 16:31
@crisbeto crisbeto requested review from amysorto and andrewseguin and removed request for a team November 9, 2024 16:31
@crisbeto crisbeto removed the request for review from amysorto November 11, 2024 12:56
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Nov 11, 2024
@crisbeto crisbeto merged commit 4f00d26 into angular:main Nov 11, 2024
24 of 27 checks passed
crisbeto added a commit that referenced this pull request Nov 11, 2024
@crisbeto
fix(material/sidenav): prevent the content from jumping when hydrated (…
75631fb 
…#29991)

Fixes that the content of the sidenav was jumping when the page is hydrated, because we can't measure the sidenav on the server.

(cherry picked from commit 4f00d26)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @andrewseguin