Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/table): set explicit role on all cells #29987

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix(cdk/table): set explicit role on all cells #29987

merged 1 commit into from
Nov 11, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Nov 8, 2024

We were omitting role="cell" on native td elements, because the browser should be setting it implicitly, but based on the discussion in #29784, it seems like Safari doesn't do it. These changes switch to always setting the role.

Fixes #29784.

@crisbeto
fix(cdk/table): set explicit role on all cells
de89255 
We were omitting `role="cell"` on native `td` elements, because the browser should be setting it implicitly, but based on the discussion in angular#29784, it seems like Safari doesn't do it. These changes switch to always setting the `role`.

Fixes angular#29784.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Nov 8, 2024
@crisbeto crisbeto requested a review from a team as a code owner November 8, 2024 12:06
@crisbeto crisbeto requested review from amysorto and mmalerba and removed request for a team November 8, 2024 12:06
@crisbeto crisbeto added the Accessibility This issue is related to accessibility (a11y) label Nov 8, 2024
@crisbeto crisbeto requested a review from andrewseguin November 8, 2024 12:06
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 11, 2024
@crisbeto crisbeto removed the request for review from andrewseguin November 11, 2024 12:55
@crisbeto crisbeto merged commit 80fdf19 into angular:main Nov 11, 2024
25 of 27 checks passed
crisbeto added a commit that referenced this pull request Nov 11, 2024
@crisbeto
fix(cdk/table): set explicit role on all cells (#29987)
a78f475 
We were omitting `role="cell"` on native `td` elements, because the browser should be setting it implicitly, but based on the discussion in #29784, it seems like Safari doesn't do it. These changes switch to always setting the `role`.

Fixes #29784.

(cherry picked from commit 80fdf19)
crisbeto added a commit that referenced this pull request Nov 11, 2024
@crisbeto
fix(cdk/table): set explicit role on all cells (#29987)
8900360 
We were omitting `role="cell"` on native `td` elements, because the browser should be setting it implicitly, but based on the discussion in #29784, it seems like Safari doesn't do it. These changes switch to always setting the `role`.

Fixes #29784.

(cherry picked from commit 80fdf19)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@amysorto amysorto amysorto approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(TABLE): cell with mat-cell directive is missing role="cell" attribute
3 participants
@crisbeto @amysorto @mmalerba