Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdk/listbox): make tabindex zoneless compatible #29970

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix(cdk/listbox): make tabindex zoneless compatible #29970

merged 1 commit into from
Nov 7, 2024

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Nov 5, 2024

fixes #29953

@mmalerba mmalerba requested a review from crisbeto November 5, 2024 22:32
@mmalerba mmalerba requested a review from a team as a code owner November 5, 2024 22:32
@mmalerba mmalerba requested review from wagnermaciel and removed request for a team November 5, 2024 22:32
@mmalerba mmalerba added the target: patch This PR is targeted for the next patch release label Nov 5, 2024
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 6, 2024
wagnermaciel
wagnermaciel approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba merged commit 17ff5be into angular:main Nov 7, 2024
22 of 24 checks passed
mmalerba added a commit that referenced this pull request Nov 7, 2024
@mmalerba
fix(cdk/listbox): make tabindex zoneless compatible (#29970)
8141e45 
(cherry picked from commit 17ff5be)
mmalerba added a commit that referenced this pull request Nov 7, 2024
@mmalerba
fix(cdk/listbox): make tabindex zoneless compatible (#29970)
1ea3ba3 
(cherry picked from commit 17ff5be)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
3 participants
@mmalerba @crisbeto @wagnermaciel