fix(form-field-custom-control-example) _focused signal not firing stateChanges #29944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManicardiFrancesco
requested review from
crisbeto and
andrewseguin
and removed request for
a team
crisbeto
approved these changes
Oct 31, 2024
crisbeto
added
docs
crisbeto
pushed a commit
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 9d4fa8f)
crisbeto
pushed a commit
that referenced
this pull request
Oct 31, 2024
(cherry picked from commit 9d4fa8f)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that form-field-custom-control-example.ts wasn't correctly handling focused events.
This can easily be checked on the official docs page or the stackblitz, here's two sample screenshots:
In the above screenshot, the user has focused the input, but the form field outline is not becoming blue.
Another failure case is when you leave the input: in this case, it will stay forever outlined in blue:
