build: update @angular/bazel to latest
#29937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
alan-agius4
force-pushed
the
angular-bazel
branch
from
a27db8e to
d233252
Compare
alan-agius4
requested review from
crisbeto and
amysorto
and removed request for
a team
alan-agius4
added
the
action: review
devversion
approved these changes
Oct 29, 2024
alan-agius4
added
the
target: rc
crisbeto
reviewed
Oct 29, 2024
| @@ -21,8 +21,6 @@ | |||
| "importHelpers": true, | |||
| "strictBindCallApply": true, | |||
| "esModuleInterop": true, | |||
| // Keep the below in sync with https://github.com/angular/angular/blob/f9b821f07d8dba57a6a7e5fc127dc096247424aa/packages/bazel/src/ng_module/ng_module.bzl#L214 | |||
| "useDefineForClassFields": false, | |||
There was a problem hiding this comment.
Does this mean that we now have useDefineForClassFields enabled?
There was a problem hiding this comment.
Is there a reason for this? I remember it had an impact on the bundle size.
There was a problem hiding this comment.
It did increase the bundle size of on older Safari versions that are no longer supported.
However, this option does improve DCE in general.
For context: angular/angular#58297
crisbeto
approved these changes
Oct 29, 2024
alan-agius4
added
action: merge
crisbeto
pushed a commit
that referenced
this pull request
Oct 29, 2024
(cherry picked from commit e35e92b)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.