docs(google-maps/map-advanced-marker): README.md added #29898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K0n4ta13
requested review from
amysorto and
mmalerba
and removed request for
a team
crisbeto
reviewed
Oct 20, 2024
| @@ -0,0 +1,44 @@ | |||
| # MapAdvancedMarker | |||
|
|
|||
| The `MapAdvancedMarker` component wraps the [`google.maps.marker.AdvancedMarkerElement` class](https://developers.google.com/maps/documentation/javascript/reference/advanced-markers) from the Google Maps JavaScript API. The `MapAdvancedMarker` component displays a marker on the map when it is a content child of a `GoogleMap` component. Like `GoogleMap`, this component offers an `options` input as well as convenience inputs for `title`, `position`, `content`, `gmpDraggable` and `zIndex`, and supports all `google.maps.marker.AdvancedMarkerElement` events as outputs. | |||
There was a problem hiding this comment.
I think we can drop the last sentence here. We shouldn't list out the individual inputs/outputs.
There was a problem hiding this comment.
Last sentence deleted.
There was a problem hiding this comment.
Apologies for splitting this into two commits. I accidentally left the outputs and the options part in the first one.
Removed list of inputs and corrected spelling.
crisbeto
approved these changes
Nov 5, 2024
crisbeto
added
action: merge
crisbeto
pushed a commit
that referenced
this pull request
Nov 5, 2024
* docs(google-maps/map-advanced-marker): README.md added * Update README.md Removed list of inputs and corrected spelling. * Update README.md (cherry picked from commit a2dc657)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add the README file.