Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/chips): emitting end event multiple times when holding down key #29894

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

crisbeto
Copy link
Member

Fixes that that the chip input was emitting the matChipEnd event while the user is holding down the separator key.

Fixes #29883.

…own key

Fixes that that the chip input was emitting the `matChipEnd` event while the user is holding down the separator key.

Fixes angular#29883.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 18, 2024
@crisbeto crisbeto requested a review from a team as a code owner October 18, 2024 07:13
@crisbeto crisbeto requested review from andrewseguin and wagnermaciel and removed request for a team October 18, 2024 07:13
@crisbeto crisbeto removed the request for review from andrewseguin October 18, 2024 13:35
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 18, 2024
@crisbeto crisbeto merged commit 5153a5c into angular:main Oct 18, 2024
25 checks passed
crisbeto added a commit that referenced this pull request Oct 18, 2024
…own key (#29894)

Fixes that that the chip input was emitting the `matChipEnd` event while the user is holding down the separator key.

Fixes #29883.

(cherry picked from commit 5153a5c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(matChipInputTokenEnd): Holding Enter Causes many matChipInputTokenEnd events
2 participants