Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(material/card): elevated card container color #29835

Merged
merged 1 commit into from
Oct 11, 2024
Merged

fix(material/card): elevated card container color #29835

merged 1 commit into from
Oct 11, 2024

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Oct 6, 2024

update elevated card container color from surface to surface-container-low matching the M3 specification

fixes #29163

before:
image
image

after:
image
image

@naaajii
fix(material/card): elevated card container color
9c7bc92 
update elevated card container color from `surface` to  `surface-container-low` matching the M3 specification

fixes angular#29163
@naaajii naaajii requested a review from a team as a code owner October 6, 2024 13:21
@naaajii naaajii requested review from amysorto and mmalerba and removed request for a team October 6, 2024 13:21
crisbeto
crisbeto approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 8, 2024
@crisbeto crisbeto merged commit 9262a01 into angular:main Oct 11, 2024
25 checks passed
crisbeto pushed a commit that referenced this pull request Oct 11, 2024
@naaajii @crisbeto
fix(material/card): elevated card container color (#29835)
2d75191 
update elevated card container color from `surface` to  `surface-container-low` matching the M3 specification

fixes #29163

(cherry picked from commit 9262a01)
This was referenced Nov 8, 2024
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(M3 mat-card): Elevated card uses the wrong surface color
2 participants
@naaajii @crisbeto