perf(cdk/table): Use ResizeObservers instead of dom measurement to re… #29814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kseamon
force-pushed
the
table-sticky-styler-resize-observer
branch
2 times, most recently
from
5107c66 to
2d61ba1
Compare
…duce layout thrashing (where possible)
kseamon
force-pushed
the
table-sticky-styler-resize-observer
branch
from
6fa630b to
afeac37
Compare
andrewseguin
approved these changes
Oct 3, 2024
andrewseguin
added
action: merge
andrewseguin
approved these changes
Oct 25, 2024
crisbeto
requested review from
crisbeto and
mmalerba
and removed request for
a team
|
I'm merging this since the internal change was submitted, causing things to be out of sync. |
crisbeto
approved these changes
Oct 28, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…duce layout thrashing (where possible)
There's still one set of measurements at startup. It might be possible to eliminate that along with some of the existing code with some additional changes but as-is this is already a substantial improvement.