-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/button-toggle): use radio pattern for single select Mat toggle button group #28548
Conversation
f79a32e
to
0a923f3
Compare
0a923f3
to
5588c4f
Compare
I added some unit test around the tab index update. |
5588c4f
to
fb07270
Compare
1b2b465
to
14d8591
Compare
f037df4
to
4c914c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good work
Deployed dev-app for 657939d to: https://ng-dev-previews-comp--pr-angular-components-28548-dev-p16tl3gz.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
c75dcc6
to
b67aeb1
Compare
On ChromeOS using screen reader, I'm not able to navigate to the button toggle component with the "Next Form Field" navigation feature. On my system that's Search + F. ChromeOS navigates past the single-select button toggle to the first button on a multiple-select button toggle. Pressing Shift + Search + F takes me in the reverse direction and puts focus on the first checkbox before the single-select button toggles. Tested on deployed dev-app. I'm surprised that Screen Reader doesn't seem to be aware that mat button toggle is a form field. We're using radiogroup role. I can look at this more tomorrow. |
"Next Form Field" seems to be working for me on VoiceOver, JAWS, NVDA. This is likely a ChromeOS specific problem. Action item to file issue report on ChromeOS Chromevox. |
I can reproduce the error with MatRadioGroup demos. I can repro both on this branch and on docs site
Action item to file issue report on ChromeOS. Filing an issue report does not block landing this PR. |
…toggle button group
b67aeb1
to
657939d
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit updates the single-select Mat toggle button group to use radio pattern. This way the exclusiveness of the selection can be conveyed to the screen reader users.