Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/table): measuring sticky row too early #28393

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 9, 2024

Fixes that after #28356 the table rows were measured too early which caused multiple sticky rows not to work as expected.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release labels Jan 9, 2024
@crisbeto crisbeto requested a review from andrewseguin as a code owner January 9, 2024 20:36
}
// Coalesce with other sticky row updates (top/bottom), sticky columns updates
// (and potentially other changes like column resize).
this._coalescedStyleScheduler.schedule(() => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty big diff, but I just moved the measurements into the schedule call.

Fixes that after angular#28356 the table rows were measured too early which caused multiple sticky rows not to work as expected.
@crisbeto crisbeto self-assigned this Jan 9, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 9, 2024
@crisbeto crisbeto merged commit d3e8a28 into angular:main Jan 10, 2024
26 checks passed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants