refactor(interactivity-checker.spec): remove redundant setTimeout usage

[belev]

No description provided.

[devversion]

The reason why a native setTimeout was used here was that the delay comes from the browser itself and can't be flushed from a zone.

I just tried to run the tests locally without the tick or setTimeout and it seems to succeed anyways (not sure what flushes the queue)

let div = document.createElement('div'); document.body.appendChild(div); div.contentEditable = true; console.log(div.tabIndex);

[belev]

Mhm interesting, maybe this should be closed then. However I will try to find why this happens.

[devversion]

@belev Sounds good. Thank you!

[belev]

After some digging around that's what I understood:

tabIndex attribute isn't set in the case where we have only contenteditable. Because of that hasValidTabIndex returns false and then getTabIndexValue returns null. So basically the tick or setTimeout didn't do anything in this case. And the test passes because of this line.

However if we access the tabIndex through the element it has value. So after all I think the mistake is in hasValidTabIndex function. I will think how to fix that.

What do you think @devversion ?

[devversion]

Ah I can see. The checks you mentioned are intentionally only respecting the user-specified tabindex instead of the evaluated one from the browser (here is a reference)

And as you said that's why the tests pass. We can remove the tick stuff safely here.

[belev]

Made the change, you can review it again. : )

[devversion]

LGTM

[jelbourn]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}