Plnkr's are always broken here is a proposal to create a system of working plunkers #6734
Comments
|
I think this is a necessary headache during the packaging shakeup. After beta, breaking changes (especially packaging ones) will be far more rare. However, I could see the autogenerated ones from the docs site pinning the version (akin to what angular core does with their issue template plunker). |
|
Additionally, code from the plnkrs throws errors when used. For example, There is no file/directory called - @angular/cdk/cdk so something is generating an incorrect path for MD components. There are other problems too numerous to mention (eg. 1. each package has to be in system.config.js, but no examples - I've tried several things and none work, and 2. lack of documentation with examples. I'm going back to beta.8 and hoping for future excellence in guiding users. |
|
@mLaird same problem here Any solutions? |
|
FWIW, I'm using SystemJS for my tests and moving to beta.9 required me to explicitly map all the CDK libraries (where I used to only need a bundle for the cdk): // Before:
'@angular/material': 'npm:@angular/material/bundles/material.umd.js',
'@angular/cdk': 'npm:@angular/cdk/bundles/cdk.umd.js',
// After:
'@angular/material': 'npm:@angular/material/bundles/material.umd.js',
'@angular/cdk': 'npm:@angular/cdk/bundles/cdk.umd.js',
'@angular/cdk/a11y': 'npm:/@angular/cdk/bundles/cdk-a11y.umd.js',
'@angular/cdk/bidi': 'npm:/@angular/cdk/bundles/cdk-bidi.umd.js',
'@angular/cdk/observers': 'npm:/@angular/cdk/bundles/cdk-observers.umd.js',
'@angular/cdk/overlay': 'npm:/@angular/cdk/bundles/cdk-overlay.umd.js',
'@angular/cdk/portal': 'npm:/@angular/cdk/bundles/cdk-portal.umd.js',
'@angular/cdk/scrolling': 'npm:/@angular/cdk/bundles/cdk-scrolling.umd.js',
'@angular/cdk/platform': 'npm:/@angular/cdk/bundles/cdk-platform.umd.js',
'@angular/cdk/keycodes': 'npm:/@angular/cdk/bundles/cdk-keycodes.umd.js',
'@angular/cdk/coercion': 'npm:/@angular/cdk/bundles/cdk-coercion.umd.js',
'@angular/cdk/collections': 'npm:/@angular/cdk/bundles/cdk-collections.umd.js',
'@angular/cdk/rxjs': 'npm:/@angular/cdk/bundles/cdk-rxjs.umd.js',
'@angular/cdk/table': 'npm:/@angular/cdk/bundles/cdk-table.umd.js', |
|
Small adjustment, which made it work for me: |
|
@jkosters We know the adjsutments work but the goal here is to try and find a more meaningful way for this not to consitently occur. |
|
The code from @benjamin Charity works for me. beta.10 now loads the page.
His code belongs in the Getting Started page to make things clear for those
of us who use systemjs.config.js
…On Thu, Sep 7, 2017 at 11:09 AM, xtianus79 ***@***.***> wrote:
@jkosters <https://github.com/jkosters> We know the adjsutments work but
the goal here is to try and find a more meaningful way for this not to
consitently occur.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6734 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADDSb4oBrCsp8LjacbfFnr9Kf9ctUacCks5sgAclgaJpZM4PHeKz>
.
--
Mike Laird
12 Arbor Creek Drive, Pittsford, New York 14534
[email protected]
". . . remembering on both sides that civility is not a sign of weakness,
and sincerity is always subject to proof. Let us never negotiate out of
fear, but let us never fear to negotiate." - John F. Kennedy
|
|
The plunkers have been fixed in the latest release. We are also working on other ways to ensure it doesn't continue to happen |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Plnkr's to this point do not have a way to centralize a working version of the application in conjunction with the way an example from material 2 works.
The proposal is in 2 choices 1 being best and the 2nd being something that can be accomplished now.
Plnkr could possibly have core components that are privately maintained and thus updated once to work across all examples. This would allowed for updated angular components and dependencies to be updated one time across the board. It would also allow for the individual feature / functionality to be adjusted on the material feature level... seperately.
Since choice [Question]: will this be the official repo for Angular 2 Material? #1 is something not likely for the now. I will propose this to them as the utility would be mightly useful... There could be a running spec of working angular plunkr that could be referenced in the docs to allow you or us to easily adjust the examples to that working spec.
Documentation and instructions for this is important because otherwise there are nothing but just broken plunkrs for documentation
What is the expected behavior?
plnkr's work
What is the current behavior?
on updates they don't work
What are the steps to reproduce?
use a plnkr
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: https://goo.gl/DlHd6U
What is the use-case or motivation for changing an existing behavior?
wish they worked
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
4.3.6
Is there anything else we should know?
nope
The text was updated successfully, but these errors were encountered: