Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs-bug(icon): The link to #29838

Closed
Cfun1 opened this issue Oct 6, 2024 · 1 comment · Fixed by #29849
Closed

docs-bug(icon): The link to #29838

Cfun1 opened this issue Oct 6, 2024 · 1 comment · Fixed by #29849
Labels
area: material/icon docs This issue is related to documentation good first issue This issue is a good place to start for first time contributors to the project P4 A relatively minor issue that is not relevant to core functions

Comments

@Cfun1
Copy link

Cfun1 commented Oct 6, 2024

Documentation Feedback

The website https://fortawesome.github.io/Font-Awesome/examples/ mentioned in the documentation below is incorret

components/src/material/icon/icon.ts

Line 130 in 76ada37

* https://fortawesome.github.io/Font-Awesome/examples/

suggestion: https://fontawesome-v4.github.io/examples/index.html

Affected documentation page

https://material.angular.io/components/icon/api
@Cfun1 Cfun1 added docs This issue is related to documentation needs triage This issue needs to be triaged by the team labels Oct 6, 2024
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions good first issue This issue is a good place to start for first time contributors to the project area: material/icon and removed needs triage This issue needs to be triaged by the team labels Oct 9, 2024
@miguelcsx miguelcsx mentioned this issue Oct 9, 2024
Merged
crisbeto pushed a commit that referenced this issue Oct 9, 2024
@miguelcsx
docs(material/icon): #29838 update broken link in icon documentation (#…
a0fc66f 
…29849)

- updated a broken link in the documentation for the icon component in
  `components/src/material/icon/icon.ts`.
crisbeto pushed a commit that referenced this issue Oct 9, 2024
@miguelcsx @crisbeto
docs(material/icon): #29838 update broken link in icon documentation (#…
cd79569 
…29849)

- updated a broken link in the documentation for the icon component in
  `components/src/material/icon/icon.ts`.

(cherry picked from commit a0fc66f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: material/icon docs This issue is related to documentation good first issue This issue is a good place to start for first time contributors to the project P4 A relatively minor issue that is not relevant to core functions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(material/icon): #29838 update broken link in icon documentation miguelcsx/components
2 participants
@crisbeto @Cfun1