Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: md-toolbar should have role of toolbar #2909

Closed
bsteffl opened this issue Feb 2, 2017 · 3 comments · Fixed by #2914
Closed

Bug: md-toolbar should have role of toolbar #2909

bsteffl opened this issue Feb 2, 2017 · 3 comments · Fixed by #2914
Assignees
Labels
Accessibility This issue is related to accessibility (a11y)

Comments

@bsteffl
Copy link

bsteffl commented Feb 2, 2017

Bug:

Md-toolbar should have role="toolbar"

What is the expected behavior?

WCAG Guidelines

What is the current behavior?

No toolbar role is announced. Would be nice to also provide keyboard functionality for
Left Arrow and Right Arrow.

What are the steps to reproduce?

<md-toolbar>
  <span>First Row</span>

  <md-toolbar-row>
    <span>Second Row</span>
  </md-toolbar-row>

  <md-toolbar-row>
    <span>Third Row</span>
  </md-toolbar-row>
</md-toolbar>

What is the use-case or motivation for changing an existing behavior?

Meet accessibility requirements

Which versions of Angular, Material, OS, browsers are affected?

2.0.0-beta.1

@kara kara added the Accessibility This issue is related to accessibility (a11y) label Feb 3, 2017
devversion added a commit to devversion/material2 that referenced this issue Feb 3, 2017
* Add the toolbar `role` attribute to the host element to have proper accessibility support.

Fixes angular#2909
@devversion
Copy link
Member

@bsteffl Thanks for the great issue reports!

Regarding keyboard interaction, I don't think that the toolbar should be responsible for such things. The toolbar is meant to be very simple and should just follow the design guidelines.

devversion added a commit to devversion/material2 that referenced this issue Feb 3, 2017
* Add the toolbar `role` attribute to the host element to have proper accessibility support.

Fixes angular#2909
devversion added a commit to devversion/material2 that referenced this issue Feb 3, 2017
* Add the toolbar `role` attribute to the host element to have proper accessibility support.

Fixes angular#2909
@bsteffl
Copy link
Author

bsteffl commented Feb 3, 2017

@devversion I appreciate your support for accessibility and being inclusive. Keyboard users will still have access to buttons via tabbing so not supporting keyboard actions works too. When I included that I was just thinking about how native OS toolbars work and users understanding of those. Thank you for your contributions.

image

tinayuangao pushed a commit that referenced this issue Feb 6, 2017
* Add the toolbar `role` attribute to the host element to have proper accessibility support.

Fixes #2909
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants