-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(cdk/dialog): Closed observable not emitting when closed by navigation #26581
Comments
Upon further inspection, it seems the material dialog is behaving properly due to this subscription on the overlay detachments: components/src/material/dialog/dialog-ref.ts Lines 90 to 94 in e6536b7
|
Fixes that the CDK dialog wasn't emitting to the `closed` event when it is detached externally, e.g. by a scroll strategy or a navigation. We had unit tests for this on the Material side, but we had special logic to handle it there. Fixes angular#26581.
Fixes that the CDK dialog wasn't emitting to the `closed` event when it is detached externally, e.g. by a scroll strategy or a navigation. We had unit tests for this on the Material side, but we had special logic to handle it there. Fixes angular#26581.
Fixes that the CDK dialog wasn't emitting to the `closed` event when it is detached externally, e.g. by a scroll strategy or a navigation. We had unit tests for this on the Material side, but we had special logic to handle it there. Fixes angular#26581.
Fixes that the CDK dialog wasn't emitting to the `closed` event when it is detached externally, e.g. by a scroll strategy or a navigation. We had unit tests for this on the Material side, but we had special logic to handle it there. Fixes angular#26581.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Is this a regression?
The previous version in which this bug was not present was
No response
Description
The
closed
observable is not emitting when the CDK dialog is being closed by navigation when thecloseOnNavigation: true
property is applied. As a side effect of the dialog not properly closing, the dialog ref is also kept in theDialog.openDialogs
list.Reproduction
Steps to reproduce:
closeOnNavigation: true
Expected Behavior
The dialog to close properly
Actual Behavior
The
closed
observable is not emtting and the dialog is being kept in de list with open dialogsEnvironment
The text was updated successfully, but these errors were encountered: