Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: md-prefix stretches together with input field #2493

Closed
Parez opened this issue Jan 2, 2017 · 1 comment · Fixed by #2496
Closed

Bug: md-prefix stretches together with input field #2493

Parez opened this issue Jan 2, 2017 · 1 comment · Fixed by #2496
Assignees
@crisbeto

Comments

@Parez
Copy link

Parez commented Jan 2, 2017 •
edited
Loading

When I put prefix in a wide md-input-container, the prefix stretches together with it.
Easy to reproduce. Just make the md-input-container wide enough:
<md-input-container class="full-width">
<span md-prefix>#</span>
<input md-input formControlName="tagInput" placeholder="Tags>
</md-input-container>

Have a look at the copyright and hash prefixes here:
screen shot 2017-01-02 at 14 32 54

I believe prefixes should stay the same width not dependent on the parent width.

Another thing (not sure if it was already mentioned) - fields disabled via code .disable() do not display as dotted. Also visible on the screenshot (field to the left of checkbox is actually disabled).
@crisbeto crisbeto self-assigned this Jan 2, 2017
@crisbeto crisbeto added the has pr label Jan 2, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 2, 2017
@crisbeto
fix(input-container): prefix and suffix stretching together with parent
3f1aa20 
Prevents the input's suffix and prefix from stretching together with their parent node and leaving some weird spacing between themselves and the input. This was a side-effect of using `display: table-cell`.

Fixes angular#2493.
@crisbeto crisbeto mentioned this issue Jan 2, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 5, 2017
@crisbeto
fix(input-container): prefix and suffix stretching together with parent
c9de8fd 
Prevents the input's suffix and prefix from stretching together with their parent node and leaving some weird spacing between themselves and the input. This was a side-effect of using `display: table-cell`.

Fixes angular#2493.
Fixes angular#1881.
Fixes angular#1421.
tinayuangao pushed a commit that referenced this issue Jan 12, 2017
@crisbeto @tinayuangao
fix(input-container): prefix and suffix stretching together with pare…
64f6d1b 
…nt (#2496)

Prevents the input's suffix and prefix from stretching together with their parent node and leaving some weird spacing between themselves and the input. This was a side-effect of using `display: table-cell`.

Fixes #2493.
Fixes #1881.
Fixes #1421.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(input-container): prefix and suffix stretching together with parent crisbeto/material2
2 participants
@crisbeto @Parez