Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha 10: Background for md-fab on <a> different then on <button> #1843

Closed
elvirdolic opened this issue Nov 12, 2016 · 6 comments
Closed

Alpha 10: Background for md-fab on <a> different then on <button> #1843

elvirdolic opened this issue Nov 12, 2016 · 6 comments

Comments

@elvirdolic
Copy link

Bug, feature request, or proposal:

Bug?

What is the expected behavior?

if you use the md-fab directive on a button the primary background color is set if you use it on a link it'ts not

What is the current behavior?

Same behavior should be for as it is for

What are the steps to reproduce?

```
<a md-fab href="http://orderlink" target="_blank">
		<md-icon class="md-24">add_shopping_cart</md-icon>
	</a>

vs

	```
<button md-fab (click)="openUploadDocumentDialog()" [disabled]="dialogRef">
            <md-icon class="md-24">add</md-icon>
        </button>

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, browsers are affected?

Is there anything else we should know?

@crisbeto
Copy link
Member

Could you post an example that shows the issue? I tried it locally with our demo app and they looked exactly the same.

@simonh1000
Copy link

simonh1000 commented Nov 14, 2016

I get the same with regular buttons:

image

<button md-raised-button color="accent" >Delete points</button>
<a [routerLink]="['upload']" md-raised-button color="accent">Return to Upload</a>

@crisbeto
Copy link
Member

Weird @simonh1000, here's what I get against master with the exact same HTML (obviously the color will be different):

material2_-_google_chrome_2016-11-14_18-45-34

@kyleledbetter
Copy link

sounds like a dup of #1801 which has an unreleased fix in master #1789

@elvirdolic
Copy link
Author

Yes this solves the issue #1789

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants