Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md-button for anchor element is visually not same as button #1801

Closed
metanav opened this issue Nov 10, 2016 · 5 comments
Closed

md-button for anchor element is visually not same as button #1801

metanav opened this issue Nov 10, 2016 · 5 comments

Comments

@metanav
Copy link
Contributor

metanav commented Nov 10, 2016

Bug, feature request, or proposal:

Bug

What is the expected behavior?

 <a  md-button color="primary" [routerLink]="['/gotosomewhere']">Click me</a>

The button created using anchor element should be visually same as button element.

What is the current behavior?

It is not same. There is no mouse (one finger hand) icon and text is dimmed.

What are the steps to reproduce?

Just upgraded from alpha9 to alpha10.

What is the use-case or motivation for changing an existing behavior?

None

Which versions of Angular, Material, OS, browsers are affected?

Material alpha10

Is there anything else we should know?

None

@kyleledbetter
Copy link

kyleledbetter commented Nov 10, 2016

it's bc it's getting disabled="false" by default and to an <a> tag that's still styled as disabled, probably from this commit 6b9e11c#diff-96337821f283af0f38c4fd8ed4c98065R46

@kyleledbetter
Copy link

'[attr.disabled]': 'disabled', <-- anchors
'[disabled]': 'disabled', <-- buttons

@Splaktar
Copy link
Member

Splaktar commented Nov 11, 2016

Yep, this is a regression that I'm seeing as well. It's caused by PR #1778. There is PR #1789 already open to fix it, but it didn't make it into alpha.10 unfortunately.

@Splaktar
Copy link
Member

Splaktar commented Nov 11, 2016

I spent a good while trying to work around this issue and override styles, etc. But it was just too much trouble. I've had to roll back to alpha.9-3.

Update: This did get into 2.0.0-alpha.11 though. Thanks!

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants