Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme colors incorrect for md-slide-toggle #1568

Closed
code-tree opened this issue Oct 22, 2016 · 2 comments · Fixed by #1612
Closed

Theme colors incorrect for md-slide-toggle #1568

code-tree opened this issue Oct 22, 2016 · 2 comments · Fixed by #1612
Assignees
@devversion
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@code-tree
Copy link
Contributor

Bug, feature request, or proposal:

Bug

What is the expected behavior?

md-slide-toggle obeys the Material Design spec

image
image

What is the current behavior?

md-slide-toggle uses background color for .md-slide-toggle-thumb, and possibly incorrect in other areas as well. This is especially noticeable in dark theme, where thumb is very hard to see.

image

What are the steps to reproduce?

Look at md-slide-toggle in both light/dark themes

What is the use-case or motivation for changing an existing behavior?

Bug

Which versions of Angular, Material, OS, browsers are affected?

"@angular/material": "^2.0.0-alpha.9-3",

Is there anything else we should know?

No
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Oct 24, 2016
devversion added a commit to devversion/material2 that referenced this issue Oct 26, 2016
@devversion
fix(slide-toggle): match theme with specs
a8c7920 
* Currently the theme stylesheet for the slide-toggle was not following the specs.

* This commit ensures that the stylesheet follows the specs with all details (https://material.google.com/components/selection-controls.html#selection-controls-switch)

Fixes angular#1568.
@devversion devversion mentioned this issue Oct 26, 2016
Merged
devversion added a commit to devversion/material2 that referenced this issue Oct 26, 2016
@devversion
fix(slide-toggle): match theme with specs
f0ea517 
* Currently the theme stylesheet for the slide-toggle was not following the specs.

* This commit ensures that the stylesheet follows the specs with all details (https://material.google.com/components/selection-controls.html#selection-controls-switch)

Fixes angular#1568.
@code-tree
Copy link
Contributor Author

Great, thanks!

@devversion devversion mentioned this issue Jun 20, 2018
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(slide-toggle): match theme with specs devversion/material2
3 participants
@jelbourn @devversion @code-tree