Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlay service #113

Closed
5 of 8 tasks
jelbourn opened this issue Feb 27, 2016 · 6 comments
Closed
5 of 8 tasks

Overlay service #113

jelbourn opened this issue Feb 27, 2016 · 6 comments
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix
Milestone

Comments

@jelbourn
Copy link
Member

jelbourn commented Feb 27, 2016

  • Portals and PortalHosts
  • DomPortalHost
  • Skeleton Overlay service
  • Overlay sizing
  • Overlay global positioning
  • Overlay relative positioning
  • Overlay scrolling
  • Overlay animation
@jelbourn jelbourn added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Feb 27, 2016
@jelbourn jelbourn self-assigned this Feb 27, 2016
@jelbourn jelbourn added this to the alpha.3 milestone Feb 27, 2016
This was referenced Feb 27, 2016
@jelbourn jelbourn modified the milestones: alpha.7, alpha.3 Apr 21, 2016
@aminebizid
Copy link

How can we help to close this issue and start interesting components

@ratscrew
Copy link

would it be possible to return the component from the promise after its attached:

line 14 from https://github.com/angular/material2/blob/master/src/core/overlay/overlay-ref.ts

  attach(portal: Portal<any>): Promise<any> {
    return this._portalHost.attach(portal).then(() => {
      this._updatePosition();
    });
  }

would there be any objection to making it:

  attach(portal: Portal<any>): Promise<any> {
    return this._portalHost.attach(portal).then((_comp) => {
      this._updatePosition();
      return _comp;
    });
  }

my current use case is for a right click context menu that I need to bind to after its attached.

@jelbourn
Copy link
Member Author

@ratscrew I might be possible to play with the generics a bit to cut out some of the any; it's definitely something I want to explore before I consider the portal / overlay stuff to be mature enough to release on its own.

@DennisSmolek
Copy link

+1 for @ratscrew's issue.. I was also just tearing my hair out trying to figure out how to access the component ref of the resulting portal component when I used the ComponentPortal.

I'm re-writing a set of components that use the dynamicComponentLoader and pass values from a directive to the resulting popup but I can't seem to access the ComponentRef any other way. For the time being I'm using the modded version..

@jelbourn
Copy link
Member Author

jelbourn commented Jun 27, 2016

Closing this issue for now, going to track remaining items in smaller issues.

andrewseguin added a commit to andrewseguin/components that referenced this issue Oct 15, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix
Projects
None yet
Development

No branches or pull requests

4 participants