Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sideNav: rename md-sidenav-layout #1055

Closed
ThomasBurleson opened this issue Aug 15, 2016 · 7 comments
Closed

sideNav: rename md-sidenav-layout #1055

ThomasBurleson opened this issue Aug 15, 2016 · 7 comments
Assignees
Labels
needs: discussion Further discussion with the team is needed before proceeding

Comments

@ThomasBurleson
Copy link

Bug, feature request, or proposal:

Current implementation uses md-sidenav-layout as the smart container for content and md-sidenav components. The -layout suffix is ambiguous and conflicts with names and concepts for the Material Layouts API and features.

What is the expected behavior?

Please rename to md-sidenav-container

What is the current behavior?

What are the steps to reproduce?

Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd

What is the use-case or motivation for changing an existing behavior?

The -layout suffix is ambiguous and conflicts with names and concepts for the Material Layouts API and features.

Which versions of Angular, Material, OS, browsers are affected?

Is there anything else we should know?

mateuszwitkowski added a commit to mateuszwitkowski/material2 that referenced this issue Aug 17, 2016
* Previous container's name (md-sidenav-layout) conflicted with names for Material Layout API and features.

Fixes angular#1055
@jelbourn
Copy link
Member

@hansl @kara any thoughts on this? I'm not convinced on the name change since we don't have any layout concepts in material2 for this to conflict with. I like the name now because I see it as more accurately capturing the intent of setting up a sidenav layout for your app (sidenav + main content area).

@hansl
Copy link
Contributor

hansl commented Aug 31, 2016

I'd rather have a proper layout engine in material2 and get rid of md-sidenav-layout. In the meantime, I agree with Thomas that container is more correct since it doesn't really affect layout.

@ThomasBurleson
Copy link
Author

ThomasBurleson commented Aug 31, 2016

@jelbourn - Also Angular Layouts is in active development and will be ready in the fall for Angular 2 apps and Angular Material 2.

I highly recommend that ngM2 does not implement a layout engine. That effort is already underway and lead by Misko.

@jelbourn
Copy link
Member

jelbourn commented Nov 3, 2016

@mmalerba I want to follow up on this with some more discussion

@mmalerba
Copy link
Contributor

Agreed with Thomas & Hans that container > layout. I'd also like to switch sidenav to drawer. A sidenav is only one possible use of the drawer component, so I propose: md-drawer-container and md-drawer

@mmalerba
Copy link
Contributor

renamed to md-sidenav-container in #2183

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
@mmalerba mmalerba added the needs: discussion Further discussion with the team is needed before proceeding label Mar 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs: discussion Further discussion with the team is needed before proceeding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants