-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sideNav: rename md-sidenav-layout #1055
Comments
* Previous container's name (md-sidenav-layout) conflicted with names for Material Layout API and features. Fixes angular#1055
@hansl @kara any thoughts on this? I'm not convinced on the name change since we don't have any layout concepts in material2 for this to conflict with. I like the name now because I see it as more accurately capturing the intent of setting up a sidenav layout for your app (sidenav + main content area). |
I'd rather have a proper layout engine in material2 and get rid of |
@jelbourn - Also Angular Layouts is in active development and will be ready in the fall for Angular 2 apps and Angular Material 2.
|
@mmalerba I want to follow up on this with some more discussion |
Agreed with Thomas & Hans that container > layout. I'd also like to switch sidenav to drawer. A sidenav is only one possible use of the drawer component, so I propose: |
renamed to md-sidenav-container in #2183 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Current implementation uses
md-sidenav-layout
as the smart container for content and md-sidenav components. The-layout
suffix is ambiguous and conflicts with names and concepts for the Material Layouts API and features.What is the expected behavior?
Please rename to
md-sidenav-container
What is the current behavior?
What are the steps to reproduce?
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd
What is the use-case or motivation for changing an existing behavior?
The
-layout
suffix is ambiguous and conflicts with names and concepts for the Material Layouts API and features.Which versions of Angular, Material, OS, browsers are affected?
Is there anything else we should know?
The text was updated successfully, but these errors were encountered: