build: replace npm with yarn - part 2 #19366
Conversation
ocombe
added
area: build & ci
|
You can preview 588d4b0 at https://pr19366-588d4b0.ngbuilds.io/. |
ocombe
force-pushed
the
build-changes
branch
from
588d4b0
to
04e3d02
Compare
|
You can preview 04e3d02 at https://pr19366-04e3d02.ngbuilds.io/. |
ocombe
force-pushed
the
build-changes
branch
from
04e3d02
to
4ed8e53
Compare
|
You can preview 4ed8e53 at https://pr19366-4ed8e53.ngbuilds.io/. |
ocombe
force-pushed
the
build-changes
branch
from
4ed8e53
to
7aa9935
Compare
ocombe
changed the title
package.json
Outdated
| @@ -104,6 +104,6 @@ | |||
| "webpack": "1.12.9", | |||
| "xhr2": "0.1.4", | |||
| "yargs": "9.0.1", | |||
| "yarn": "1.0.2" | |||
| "yarn": "1.1.0" | |||
There was a problem hiding this comment.
why do we have a local yarn? that seems wrong. Can't we just always use the global?
There was a problem hiding this comment.
we probably can yes, I'll check
| @@ -10,4 +10,4 @@ echo "#################################" | |||
|
|
|||
| yarn install | |||
|
|
|||
| npm run test | |||
| yarn test || exit 1 | |||
There was a problem hiding this comment.
why "|| exit 1" ? we already have "set -e" at the top
There was a problem hiding this comment.
ah I didn't know what set -e did, I'll remove the exit 1 then (I put it there because it was used in the integration tests I think)
IgorMinar
added
action: cleanup
ocombe
force-pushed
the
build-changes
branch
3 times, most recently
from
ffa7777
to
837827b
Compare
|
You can preview 837827b at https://pr19366-837827b.ngbuilds.io/. |
|
You can preview 2c18056 at https://pr19366-2c18056.ngbuilds.io/. |
|
@ocombe, isn't this obsolete? if so can you please close it? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Type
What kind of change does this PR introduce?
What is the current behavior?
I forgot to replace some npm commands with yarn in my previous PR
What is the new behavior?
Yarn all the way.
I also updated yarn to 1.1.0 which was just released and has a much better support for peer dependencies (see yarnpkg/yarn#4478)
Does this PR introduce a breaking change?