Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio: redirect https://angular.io/styleguide -> guide/styleguide #22078

Closed
wardbell opened this issue Feb 8, 2018 · 3 comments
Closed

aio: redirect https://angular.io/styleguide -> guide/styleguide #22078

wardbell opened this issue Feb 8, 2018 · 3 comments
Labels
freq2: medium regression Indicates than the issue relates to something that worked in a previous version type: bug/fix
Milestone
Backlog

Comments

@wardbell
Copy link
Contributor

wardbell commented Feb 8, 2018 •
edited
Loading

I'm submitting a...


[x] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question

Current behavior

This old v1, once valid styleguide URL, https://angular.io/styleguide, now is a 404.

Minko Gechev tells me

This breaks a lot of releases of codelyzer + the printed content of my book.

It used to redirect to its current location, https://angular.io/guide/styleguide.

Redirects were recently updated. Maybe there is a much bigger regression here?

Expected behavior

  • Should redirect.
  • Should confirm that our old v1 to v2 redirects are still working.

Minimal reproduction of the problem with instructions

Go to https://angular.io/styleguide
@wardbell wardbell changed the title aio: redirect https://angular.io/styleguide -> https://angular.io/guide/styleguide aio: redirect https://angular.io/styleguide -> guide/styleguide Feb 8, 2018
@IgorMinar IgorMinar added freq2: medium regression Indicates than the issue relates to something that worked in a previous version type: bug/fix labels Feb 8, 2018
@ngbot ngbot bot added this to the Backlog milestone Feb 8, 2018
@IgorMinar
Copy link
Contributor

// @mgechev

@petebacondarwin
Copy link
Contributor

I'll fix this today

@mgechev mgechev mentioned this issue Feb 8, 2018
Closed
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue Feb 8, 2018
@petebacondarwin
fix(aio): do not rewrite /styleguide URL in Service Worker
8e1f1e3 
This URL needs to be redirected via the server, so
we must exclude it from being rewitten.

Closes angular#22078
@petebacondarwin petebacondarwin mentioned this issue Feb 8, 2018
Closed
petebacondarwin added a commit to petebacondarwin/angular that referenced this issue Feb 8, 2018
@petebacondarwin
fix(aio): do not rewrite /styleguide URL in Service Worker
973578f 
This URL needs to be redirected via the server, so
we must exclude it from being rewitten.

Closes angular#22078
mhevery pushed a commit that referenced this issue Feb 9, 2018
@petebacondarwin @mhevery
fix(aio): do not rewrite /styleguide URL in Service Worker (#22104)
d4a9db2 
This URL needs to be redirected via the server, so
we must exclude it from being rewitten.

Closes #22078

PR Close #22104
@mhevery mhevery closed this as completed in 5fc77c9 Feb 9, 2018
jbogarthyde pushed a commit to jbogarthyde/angular that referenced this issue Feb 23, 2018
@petebacondarwin @jbogarthyde
fix(aio): do not rewrite /styleguide URL in Service Worker (angular#2…
f9a6884 
…2085)

This URL needs to be redirected via the server, so
we must exclude it from being rewitten.

Closes angular#22078

PR Close angular#22085
leo6104 pushed a commit to leo6104/angular that referenced this issue Mar 25, 2018
@petebacondarwin @leo6104
fix(aio): do not rewrite /styleguide URL in Service Worker (angular#2…
9d37f96 
…2085)

This URL needs to be redirected via the server, so
we must exclude it from being rewitten.

Closes angular#22078

PR Close angular#22085
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
freq2: medium regression Indicates than the issue relates to something that worked in a previous version type: bug/fix
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix(aio): do not rewrite /styleguide URL in Service Worker petebacondarwin/angular
3 participants
@petebacondarwin @wardbell @IgorMinar