Skip to content

Commit

Permalink
fix(language-service): non-existent module format in package output (#…
Browse files Browse the repository at this point in the history
…37778)

The language-service package currently sets the `module` `package.json`
property and refers to a folder called `fesm5`. The language-service
though does not build with `ng_package` so this folder never existed.
Now with APF v10, ng package would not generate this folder either.

We should just remove the property as the primary entry-point is
the UMD bundle resolved through `main`. There is no module flavour
exposed to the NPM package as `pkg_npm` uses the named AMD module
devmode output that doesn't work for `module`.

PR Close #37778
  • Loading branch information
devversion authored and atscott committed Jul 10, 2020
1 parent 5be3236 commit 12f1773
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/language-service/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"version": "0.0.0-PLACEHOLDER",
"description": "Angular - language services",
"main": "./bundles/language-service.umd.js",
"module": "./fesm5/language-service.js",
"typings": "./index.d.ts",
"author": "angular",
"license": "MIT",
Expand Down

0 comments on commit 12f1773

Please sign in to comment.