fix($parse): correctly assign expressions who's path is undefined and that use brackets notation #8113

rodyhaddad · 2014-07-08T22:45:00Z

mary-poppins · 2014-07-08T22:45:03Z

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

Uses the issue template (#8113)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

rodyhaddad · 2014-07-14T18:28:36Z

src/ng/parse.js

@@ -708,6 +710,7 @@ Parser.prototype = {
        var key = indexFn(self, locals);
        // prevent overwriting of Function.constructor which would break ensureSafeObject check
        var safe = ensureSafeObject(obj(self, locals), parser.text);
+        if (!safe) obj.assign(self, safe = {});
        return safe[key] = value;


Check if key is safeName first

lgalfaso · 2014-07-17T20:08:10Z

I am somehow torn on this PR, the main reason being that people expect that for the expression a[0], that a is an array

… that use brackets notation Closes angular#8039

rodyhaddad · 2014-07-27T06:37:33Z

The initial issue is a symptom of a too forgiving expression language.

Talking with @IgorMinar, the array scenario isn't worth handling for now.
We'll address it if someone complains with a good use case :-)

Landed as c03ad24 and 60366c8

rodyhaddad added cla: yes and removed cla: no labels Jul 8, 2014

Narretz added this to the 1.3.0 milestone Jul 9, 2014

Narretz added component: $parse labels Jul 9, 2014

rodyhaddad reviewed Jul 14, 2014
View reviewed changes

rodyhaddad self-assigned this Jul 15, 2014

fix($parse): correctly assign expressions who's path is undefined and…

0601fcd

… that use brackets notation Closes angular#8039

rodyhaddad closed this Jul 27, 2014

rodyhaddad mentioned this pull request Jul 27, 2014

ng-model pointing to an expression containing square brackets fail if a middle value is undefined #8039

Closed

rodyhaddad mentioned this pull request Aug 26, 2014

Expression parser inconsistency with bracket notation #2845

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix($parse): correctly assign expressions who's path is undefined and that use brackets notation #8113

fix($parse): correctly assign expressions who's path is undefined and that use brackets notation #8113

rodyhaddad commented Jul 8, 2014

mary-poppins commented Jul 8, 2014

rodyhaddad Jul 14, 2014

lgalfaso commented Jul 17, 2014

rodyhaddad commented Jul 27, 2014

fix($parse): correctly assign expressions who's path is undefined and that use brackets notation #8113

fix($parse): correctly assign expressions who's path is undefined and that use brackets notation #8113

Conversation

rodyhaddad commented Jul 8, 2014

mary-poppins commented Jul 8, 2014

rodyhaddad Jul 14, 2014

Choose a reason for hiding this comment

lgalfaso commented Jul 17, 2014

rodyhaddad commented Jul 27, 2014