Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

opal compatability as suggested in #2653 #7904

Closed
wants to merge 1 commit into from
Closed

opal compatability as suggested in #2653 #7904

wants to merge 1 commit into from

Conversation

MichaelSp
Copy link

As suggested here #2653 (comment)
See discussion in #2653

Any chance to get this integrated eventually?

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@MichaelSp
Copy link
Author

Before going through the bureaucracy, what are the chances for this PR to get merged?

@MichaelSp
Copy link
Author

Oh and if this is an issue, consider my change as public domain. Or change that line yourself if you want to

IgorMinar added a commit that referenced this pull request Jun 24, 2014
@IgorMinar
fix($injector): check if a fn is an array explicitly
67c11b9 
This change makes the code easier to read and also fixes a compatibility issue
with opal.js which pollutes the global state by setting $inject property on
Array prototype

Closes #7904
Closes #2653
@IgorMinar IgorMinar closed this in b1a6baa Jun 24, 2014
@IgorMinar
Copy link
Contributor

usually I'd say fix the problem in opal.js because they are the source of the problem, but I agree that our code is not the cleanest, so I fixed it.

ckknight pushed a commit to ckknight/angular.js that referenced this pull request Jul 16, 2014
@IgorMinar
fix($injector): check if a fn is an array explicitly
cf6ba31 
This change makes the code easier to read and also fixes a compatibility issue
with opal.js which pollutes the global state by setting $inject property on
Array prototype

Closes angular#7904
Closes angular#2653
@theurere theurere mentioned this pull request Aug 26, 2014
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: no
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MichaelSp @mary-poppins @IgorMinar